Development Guidelines we try to adhere to

On this page you will find a set of code rules and general development workflow we try to impose in the coreBOS project. I strongly recommend that all developers who want to contribute to the project read these guidelines and try to apply them as much as possible. I will take them into consideration at the moment of accepting code contributions.

In general I am paraphrasing the PHP FIG - RECTIFIED, PHP-FIG Standards Recommendations, and Produccing Open Source Software, but with some minor adjustments to the reality of our code base. So anything you read there is useful.

The best place to contact the developer community is on our gitter chat group.

The blog is mostly developer oriented and there is a lot of information here on the documentation site.

You can ask in the forum also, but don't hesitate to get in touch, we are a really friendly and helpful community.

The project lives on github and we recommend following the typical fork and pull request procedure. Read here for the exact steps.

Use the github issues section (prefered) or the Mantis bug tracker. Read here for some additional ideas.

In general the next sections apply both to PHP and Javascript code. Each has their own particularities, but we should try to be as consistent as possible.

We are currently not following this recommendation. We load the files we need using require or include from wherever they have been added in the project.

We will probably get to this in the future but it is not a high priority right now.

PSR-2: Basic Coding Standard

• Files MUST use only <?php tags, no short tags nor any others
• Files MUST use only UTF-8 without BOM.
• Files SHOULD either declare symbols (classes, functions, constants, etc.) or cause side-effects (e.g. generate output, change .ini settings, etc.) but SHOULD NOT do both. This is a good recommendation but it is not present at all in our code base, so if you follow it fine, if not it's ok.
• Namespaces and classes MUST follow an “autoloading” PSR: [PSR-0, PSR-4].
• Class names MUST be declared in StudlyCaps.
• Class constants MUST be declared in all upper case with underscore separators.
• Method names MUST be declared in camelCase.

PSR-2: Coding Style Guide

• Code MUST use 1 tab for indenting, not spaces. Reasoning behind it and a Spaces-vs-Tabs and Brace-Styles evaluation
• There is a recommended hard limit on line length set to 180; the soft limit MUST be 170 characters; lines SHOULD be 80 characters or less.
• There MUST NOT be trailing whitespace at the end of non-blank lines.
• There MUST be one blank line after the namespace declaration, and there MUST be one blank line after the block of use declarations.
• Visibility MUST be declared on all properties and methods; abstract and final MUST be declared before the visibility; static MUST be declared after the visibility.
• Control structure keywords MUST have one space after them; method and function calls MUST NOT.
• Opening braces for classes, methods, functions, and control structures MUST go on the same line, and closing braces MUST go on the next line after the body.
• Opening parentheses for control structures MUST NOT have a space after them, and closing parentheses for control structures MUST NOT have a space before.
• Strings should be enclosed in SINGLE QUOTES where possible.

The Nextcloud coding style is a very sane set of rules also

All development MUST be done using error_reporting set to E_ALL and we should not leave any warning nor notice in the code. They must all be eliminated.

If you run into a part of the code that emits a lot of warnings, either dedicate some time to eliminating them or send me the details and I will take care of it.

All development MUST be done using MySQL Strict Mode and we should fix any SQL commands that we create.

If you run into a part of the code that has some SQL Strict error, either dedicate some time to eliminating it or send me the details and I will take care of it.

Security is a very complex and important issue which requires a lot of dedication and time. In other words, dedicate time to studying and understanding security issues.

• use vtlib_purify on all incoming and outgoing information
• user Vtiger_Request to construct URLs

Read the Nextcloud recommendations

This is a list of things that you MUST do before executing a commit:

• git diff check all the files that have been modified, read the diff, and mentally review the change. eliminate debug messages and passwords.
• Check for debug messages you may have left behind. Before I launch a commit I usually execute these commands:

  git diff {files} | grep dump
  git diff {files} | grep fatal
  git diff {files} | grep log

• Check for php errors

  for f in {diff file list}; do php -l $f; done;

• git status any new/untracked files to add?
• Any strings that should be translated?
• If you alter an existing function, did you check if all the existing references to that function will still behave the same way?
• If you created new code, did you try and use existing functionality as much as possible?
• code formatting
• Ideally you should run a lint process on both PHP and javascript. Please look below for the tools we use and how to execute them. I will add it to the Pull Request acceptance process at some point.
• see the checkfile executable below
• Did you execute the unit tests and/or e2e tests?
• git add -p to separate commits into semantically meaningful chunks. Check if you must separate the code changes in various commits. When I program I usually make some cosmetic changes or modifications that are not related to the requirement I am implementing. You can use the “-p” directive to split unrelated changes creating concise and cohesive commit changes.
• dedicate a moment to think about the commit message
• Any documentation that should be added to the wiki?

These are the steps to update the service worker:

fold service-worker.js > sold
include/sw-precache/regen_swprecache
fold service-worker.js > snew
meld sold snew
# make sure the update is about the files you know have changed
# the typical error here is for the update to include some javascript or css code you have not committed yet
rm sold snew

Always commit the service worker update in it's own commit. Do not mix it with any other changes. This way we can safely ignore all those commits when searching, or easily locate changes when needed.

We recommend and use two tools to help validating the formatting issues in PHP and Javascript files.

• PHP Code Sniffer for PHP
• ESLint for Javascript
• PHP Mess Detector

You can find rulesets for the above guidelines in the build/cbSR directory.

For example, to validate a PHP file you can execute:

./phpcs.phar --standard=build/cbSR file_to_validate

You could also execute this command on javascript files, but eslint is better:

eslint -c build/cbSR/eslintrc.js file_to_validate

I actually bundle phpcs and phpmd in one file (checkfile) that I use to validate my php files:

echo ======
echo $1
echo ======
phpcs.phar --standard=/var/www/coreBOSwork/build/cbSR $1
phpmd.phar $1 text unusedcode
php -l $1

• Custom modules:
  • Each module must have it's own repository
  • You must try to keep the modules' repository in sync with the installs where it is in production
  • Since that is a bit difficult what I do is update them when I need to install them somewhere
  • Register your module in the extensions section so it can be found in the future. You can use the helper scripts.
• There MUST NOT be any unversioned changes in production. This is MANDATORY
• For EVERY change or customization that you have to do in coreBOS, challenge yourself to find a way to make that change without modifying one line of base code that you can find in the github repository. You will be surprised how much can be done, you will learn a lot and have much more fun

• Debugging
• Commit Guidelines we try to adhere to
• How to Contribute
• Bug Reports
• PHP Framework Interop Group
• PHP Framework Interoperability Group - RECTIFIED
• Produccing Open Source Software
• AngularJS Git Commit Message Conventions
• PHP Code Sniffer
• ESLint
• Writing Consistent, Idiomatic JavaScript
• JavaScript, The Right Way